[ 
https://issues.apache.org/jira/browse/HADOOP-11247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189077#comment-14189077
 ] 

Yongjun Zhang commented on HADOOP-11247:
----------------------------------------

Hi [~brandonli],

Thanks for working on this. 

I reviewed the patch and have one question, if user didn't specify old config 
property "nfs.static.mapping.file" before, then the old default value 
"/etc/nfs.map" was expected. Now with this change, even if user has 
"/etc/nfs.map" file, user still need to rename /etc/nfs.map" to 
"/ect/usergroupid.map". So it's kind of breaking backward compatibility. That 
said, I don't see a good solution here to really maintain the full backward 
compatibility. I just want to point this out. Comments? thanks.




> Fix a couple javac warnings in NFS
> ----------------------------------
>
>                 Key: HADOOP-11247
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11247
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: nfs
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HADOOP-11247.001.patch, HADOOP-11247.002.patch
>
>
> This JIRA is to fix 2 javac warnings, which are overlooked in HADOOP-11195.
> {format}
> 241a242,243
> > [WARNING] 
> > /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfiguration.java:[46,41]
> >  [deprecation] NFS_USERGROUP_UPDATE_MILLIS_KEY in 
> > org.apache.hadoop.nfs.nfs3.Nfs3Constant has been deprecated
> > [WARNING] 
> > /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfiguration.java:[48,41]
> >  [deprecation] NFS_STATIC_MAPPING_FILE_KEY in 
> > org.apache.hadoop.nfs.nfs3.Nfs3Constant has been deprecated
> {format}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to