[ 
https://issues.apache.org/jira/browse/HADOOP-11247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14189150#comment-14189150
 ] 

Yongjun Zhang commented on HADOOP-11247:
----------------------------------------

HI Brandon,

Thanks a lot for quickly addressing my comments, and your latest patch looks 
good to me. 

We tried to remove the keyword "nfs" from IdMappingConstant.java, which was why 
I said there was no good solution to main full backward compatibility. Now with 
a little imperfection of having one appearance of "nfs" in this file, we are 
able to have full backward compatibility. So the patch looks reasonable to me. 
Thanks again for addressing that.




> Fix a couple javac warnings in NFS
> ----------------------------------
>
>                 Key: HADOOP-11247
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11247
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: nfs
>    Affects Versions: 2.6.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HADOOP-11247.001.patch, HADOOP-11247.002.patch, 
> HADOOP-11247.003.patch
>
>
> This JIRA is to fix 2 javac warnings, which are overlooked in HADOOP-11195.
> {format}
> 241a242,243
> > [WARNING] 
> > /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfiguration.java:[46,41]
> >  [deprecation] NFS_USERGROUP_UPDATE_MILLIS_KEY in 
> > org.apache.hadoop.nfs.nfs3.Nfs3Constant has been deprecated
> > [WARNING] 
> > /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/conf/NfsConfiguration.java:[48,41]
> >  [deprecation] NFS_STATIC_MAPPING_FILE_KEY in 
> > org.apache.hadoop.nfs.nfs3.Nfs3Constant has been deprecated
> {format}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to