[
https://issues.apache.org/jira/browse/HADOOP-11322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220605#comment-14220605
]
Hadoop QA commented on HADOOP-11322:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12682584/HADOOP-11322.patch
against trunk revision c298a9a.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-kms.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5110//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5110//console
This message is automatically generated.
> key based ACL check in KMS always check KeyOpType.MANAGEMENT even actual
> KeyOpType is not MANAGEMENT
> -----------------------------------------------------------------------------------------------------
>
> Key: HADOOP-11322
> URL: https://issues.apache.org/jira/browse/HADOOP-11322
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.6.0
> Reporter: Dian Fu
> Assignee: Dian Fu
> Attachments: HADOOP-11322.patch
>
>
> In the method checkAccess of class KeyAuthorizationKeyProvider, there is
> following code:
> {code}
> private void checkAccess(String aclName, UserGroupInformation ugi,
> KeyOpType opType) throws AuthorizationException {
> Preconditions.checkNotNull(aclName, "Key ACL name cannot be null");
> Preconditions.checkNotNull(ugi, "UserGroupInformation cannot be null");
> if (acls.isACLPresent(aclName, KeyOpType.MANAGEMENT) &&
> (acls.hasAccessToKey(aclName, ugi, opType)
> || acls.hasAccessToKey(aclName, ugi, KeyOpType.ALL))) {
> return;
> }
> ...
> }
> {code}
> Seems that {code}
> acls.isACLPresent(aclName, KeyOpType.MANAGEMENT) {code}
> should be replaced with {code}
> acls.isACLPresent(aclName, opType) {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
