[
https://issues.apache.org/jira/browse/HADOOP-11322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224375#comment-14224375
]
Hudson commented on HADOOP-11322:
---------------------------------
FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #16 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/16/])
HADOOP-11322. key based ACL check in KMS always check KeyOpType.MANAGEMENT even
actual KeyOpType is not MANAGEMENT. (Dian Fu via yliu) (yliu: rev
61a2510b55317867c8539a4df295f5afb85da5d4)
* hadoop-common-project/hadoop-common/CHANGES.txt
*
hadoop-common-project/hadoop-kms/src/test/java/org/apache/hadoop/crypto/key/kms/server/TestKMS.java
*
hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KeyAuthorizationKeyProvider.java
> key based ACL check in KMS always check KeyOpType.MANAGEMENT even actual
> KeyOpType is not MANAGEMENT
> -----------------------------------------------------------------------------------------------------
>
> Key: HADOOP-11322
> URL: https://issues.apache.org/jira/browse/HADOOP-11322
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.6.0
> Reporter: Dian Fu
> Assignee: Dian Fu
> Fix For: 2.7.0
>
> Attachments: HADOOP-11322.patch, HADOOP-11322.patch.2
>
>
> In the method checkAccess of class KeyAuthorizationKeyProvider, there is
> following code:
> {code}
> private void checkAccess(String aclName, UserGroupInformation ugi,
> KeyOpType opType) throws AuthorizationException {
> Preconditions.checkNotNull(aclName, "Key ACL name cannot be null");
> Preconditions.checkNotNull(ugi, "UserGroupInformation cannot be null");
> if (acls.isACLPresent(aclName, KeyOpType.MANAGEMENT) &&
> (acls.hasAccessToKey(aclName, ugi, opType)
> || acls.hasAccessToKey(aclName, ugi, KeyOpType.ALL))) {
> return;
> }
> ...
> }
> {code}
> Seems that {code}
> acls.isACLPresent(aclName, KeyOpType.MANAGEMENT) {code}
> should be replaced with {code}
> acls.isACLPresent(aclName, opType) {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
