[
https://issues.apache.org/jira/browse/HADOOP-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359574#comment-14359574
]
Steve Loughran commented on HADOOP-11710:
-----------------------------------------
Looking at the code, it seems OK to me, so +1
However, I would recommend one change, which is in {{close()}}, move the
close=true operation up immediately after the close check, just in case
something in {{freeBuffers() }} raised an exception or the parent did -it'll
stop a second close() call getting into a mess. This is not really related to
the rest of the patch, except in the general "improve re-entrancy" context
> Make CryptoOutputStream behave like DFSOutputStream wrt synchronization
> -----------------------------------------------------------------------
>
> Key: HADOOP-11710
> URL: https://issues.apache.org/jira/browse/HADOOP-11710
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: 2.6.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Critical
> Attachments: HADOOP-11710.1.patch.txt
>
>
> per discussion on parent, as an intermediate solution make CryptoOutputStream
> behave like DFSOutputStream
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
