[ https://issues.apache.org/jira/browse/HADOOP-11710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14359743#comment-14359743 ]
Yi Liu commented on HADOOP-11710: --------------------------------- Oh, I just see Steve's comments {quote} However, I would recommend one change, which is in close(), move the close=true operation up immediately after the close check, just in case something in {{freeBuffers() }} raised an exception or the parent did -it'll stop a second close() call getting into a mess. This is not really related to the rest of the patch, except in the general "improve re-entrancy" contex {quote} I agree we should make {{closed}} be set to false, also I think use sun's API to release directbuffer rarely failed. Maybe we can put it in {{try... finally}}. > Make CryptoOutputStream behave like DFSOutputStream wrt synchronization > ----------------------------------------------------------------------- > > Key: HADOOP-11710 > URL: https://issues.apache.org/jira/browse/HADOOP-11710 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs > Affects Versions: 2.6.0 > Reporter: Sean Busbey > Assignee: Sean Busbey > Priority: Critical > Attachments: HADOOP-11710.1.patch.txt, HADOOP-11710.2.patch.txt > > > per discussion on parent, as an intermediate solution make CryptoOutputStream > behave like DFSOutputStream -- This message was sent by Atlassian JIRA (v6.3.4#6332)