[
https://issues.apache.org/jira/browse/HADOOP-12056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14573230#comment-14573230
]
Lei (Eddy) Xu commented on HADOOP-12056:
----------------------------------------
Hi, [~zxu] Thanks for updating the patch.
bq. I tried, but it is failed with "Not a directory" exception at
DiskChecker#checkDirAccess
What would be the real problem to fix in this patch? Is the {{Null}} due to the
input is a file or an IO error?
If the later is the case, would it be OK to use {{DirectoryStream}} instead of
{{listFiles()}}, as it can report {{IOException}}. Also we should test against
this case.
> DiskChecker#checkDirs should check null pointer for the return value from
> File#listFiles to avoid NPE.
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-12056
> URL: https://issues.apache.org/jira/browse/HADOOP-12056
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 2.7.0
> Reporter: zhihai xu
> Assignee: zhihai xu
> Attachments: HADOOP-12056.000.patch, HADOOP-12056.001.patch
>
>
> DiskChecker#checkDirs should check null pointer for the return value from
> File#listFiles. Based on the document for File#listFiles at
> https://docs.oracle.com/javase/7/docs/api/java/io/File.html#listFiles() :
> {code}
> Returns null if an I/O error occurs.
> {code}
> So it will be good to check null pointer and throw DiskErrorException if it
> is null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
