[ https://issues.apache.org/jira/browse/HADOOP-12056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14575030#comment-14575030 ]
Hadoop QA commented on HADOOP-12056: ------------------------------------ \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 16m 20s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 34s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 40s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:green}+1{color} | checkstyle | 1m 8s | There were no new checkstyle issues. | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 35s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 50s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | common tests | 22m 33s | Tests passed in hadoop-common. | | | | 61m 38s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12737995/HADOOP-12056.003.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 7588585 | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/6930/artifact/patchprocess/testrun_hadoop-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/6930/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6930/console | This message was automatically generated. > DiskChecker#checkDirs should check null pointer for the return value from > File#listFiles to avoid NPE. > ------------------------------------------------------------------------------------------------------ > > Key: HADOOP-12056 > URL: https://issues.apache.org/jira/browse/HADOOP-12056 > Project: Hadoop Common > Issue Type: Bug > Components: util > Affects Versions: 2.7.0 > Reporter: zhihai xu > Assignee: zhihai xu > Attachments: HADOOP-12056.000.patch, HADOOP-12056.001.patch, > HADOOP-12056.002.patch, HADOOP-12056.003.patch > > > DiskChecker#checkDirs should check null pointer for the return value from > File#listFiles. Based on the document for File#listFiles at > https://docs.oracle.com/javase/7/docs/api/java/io/File.html#listFiles() : > {code} > Returns null if an I/O error occurs. > {code} > So it will be good to check null pointer and throw DiskErrorException if it > is null. -- This message was sent by Atlassian JIRA (v6.3.4#6332)