[ https://issues.apache.org/jira/browse/HADOOP-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14653427#comment-14653427 ]
Hadoop QA commented on HADOOP-8602: ----------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 16m 42s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 1 new or modified test files. | | {color:green}+1{color} | javac | 7m 37s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 37s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 24s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 1m 5s | The applied patch generated 1 new checkstyle issues (total was 6, now 7). | | {color:red}-1{color} | whitespace | 0m 0s | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 21s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 53s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:red}-1{color} | common tests | 21m 46s | Tests failed in hadoop-common. | | | | 61m 1s | | \\ \\ || Reason || Tests || | Failed unit tests | hadoop.fs.ftp.TestFTPFileSystem | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12748634/HADOOP-8602.004.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 9a08999 | | checkstyle | https://builds.apache.org/job/PreCommit-HADOOP-Build/7406/artifact/patchprocess/diffcheckstylehadoop-common.txt | | whitespace | https://builds.apache.org/job/PreCommit-HADOOP-Build/7406/artifact/patchprocess/whitespace.txt | | hadoop-common test log | https://builds.apache.org/job/PreCommit-HADOOP-Build/7406/artifact/patchprocess/testrun_hadoop-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-HADOOP-Build/7406/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/7406/console | This message was automatically generated. > Passive mode support for FTPFileSystem > -------------------------------------- > > Key: HADOOP-8602 > URL: https://issues.apache.org/jira/browse/HADOOP-8602 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 1.0.3, 2.0.0-alpha > Reporter: Nemon Lou > Priority: Minor > Labels: BB2015-05-TBR > Attachments: HADOOP-8602.004.patch, HADOOP-8602.patch, > HADOOP-8602.patch, HADOOP-8602.patch > > > FTPFileSystem uses active mode for default data connection mode.We shall be > able to choose passive mode when active mode doesn't work (firewall for > example). > My thoughts is to add an option "fs.ftp.data.connection.mode" in > core-site.xml.Since FTPClient(in org.apache.commons.net.ftp package) already > supports passive mode, we just need to add a few code in FTPFileSystem > .connect() method. -- This message was sent by Atlassian JIRA (v6.3.4#6332)