[ 
https://issues.apache.org/jira/browse/HADOOP-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658484#comment-14658484
 ] 

Steve Loughran commented on HADOOP-8602:
----------------------------------------

Like you note, the amount of testing for FTP is ~= 0.

there's some under {{org/apache/hadoop/fs/contract/ftp}};  they use instances 
of {{FTPContract}} to decide whether to run the tests or not. Essentially, if 
the configuration in the (git/svn ignored) file 
{{test/resources/"contract-test-options.xml}} contains the key {{test.fs.ftp}}, 
the ftp URL so defined is used as the test target. If the key is missing, the 
tests are skipped. 

There's some detail [In the online 
docs|http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-common/filesystem/testing.html]

I'd recommend that
# you get your setup into a state where those tests are running
# you extend them/add a new contract test to test new features.

The FTP fs doesn't get much attention; it's primary use is a read-only server 
of data. And if you search for "hadoop ftp open" there's a short list of 
outstanding issues. Its a non-critical component & the risk of major breakages 
is low: it just needs someone to sit down & fix things. Thank you for 
volunteering :)

> Passive mode support for FTPFileSystem
> --------------------------------------
>
>                 Key: HADOOP-8602
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8602
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 1.0.3, 2.0.0-alpha
>            Reporter: Nemon Lou
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: HADOOP-8602.004.patch, HADOOP-8602.005.patch, 
> HADOOP-8602.006.patch, HADOOP-8602.patch, HADOOP-8602.patch, HADOOP-8602.patch
>
>
>  FTPFileSystem uses active mode for default data connection mode.We shall be 
> able to choose passive mode when active mode doesn't work (firewall for 
> example).
>  My thoughts is to add an option "fs.ftp.data.connection.mode" in 
> core-site.xml.Since FTPClient(in org.apache.commons.net.ftp package) already 
> supports passive mode, we just need to add a few code in FTPFileSystem 
> .connect() method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to