Hi Robert, take your time.
The reason for me to change the basic rules is, that it is transparent to existing code. You will see that instantly when you look at the code. On knowledge about rulesets: The object get's the digester instance so it has full access to the rules that already are in place. In addition to what I sent, it may be sensible to provide the attributes as well, to enable attribute specific configuration. On debugging. Yes, it looks like it complicates, but on the other hand it enables better structuring by encapsulation, because you can keep the tag specific configuration in the regarding object itself. I thought about limiting the rules to tags nested inside the tag that caused the configuration method to be called, but that is much more complicated. Mika ----- Original Message ----- From: "robert burrell donkin" <[EMAIL PROTECTED]> To: "Jakarta Commons Developers List" <[EMAIL PROTECTED]> Sent: Thursday, December 13, 2001 7:07 PM Subject: Re: selfconfiguring objects patch for digester i haven't had a look at this patch in detail but i'd like the chance to take a decent look and have a little think about it before it's committed. FWIW, my gut instinct is that modifying basic rules is the wrong way to implement this feature and there has to be a better way. a self configuring object would have to know about the matching ruleset in order to create the appropriate matching patterns. the pattern matching rules we have at the moment are fairly compatible but there has been demand for pattern matching rules using incompatible patterns (eg. XPath). the other possible wrinkle is that large rulesets are difficult enough to debug as it is - but by allowing self-configuring object to dynamically change the rules, debugging these rulesets could become nearly impossible. - robert On Thursday, December 13, 2001, at 03:51 PM, Mika Goeckel wrote: > Hi, > > please find attached my changes to Digester, ObjectCreateRule and > ObjectCreationFactory + two new interfaces (source in the jar). > I think my docu is not that good -- English is not my mother tongue. > > Some example is in the documentation of SelfConfigureObject. > > Looking forward to your comments. > > Mika > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]. > org> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]. > org> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
