apologies from being incommunicado for a while (i've been sick). i've definitely fixed this bug. i thought that i'd also posted a message to the list (and hopefully cc'd it to Klaasjan) about the fix.
there were various reasons why i didn't use the patch submitted (basically stylistic) but i also fixed another possible problem and added some new tests. so i'd prefer it if my fix stayed (providing, of course, that Klaasjan can verify that it works). i not really up to speed on the bugzilla etiquette here in the commons (and could quite possible require bugzilla karma) so i haven't cleared the bug report yet. i'm feeling better now so if someone can point me in the right direction i'll have a go at tackling bugzilla... - robert On Tuesday, April 9, 2002, at 10:49 AM, Klaasjan Brand wrote: > Of course... > > greets, > Klaasjan Brand > > > Scott Sanders wrote: >> Could you post the patch again? >> Thanks >> Scott >>> -----Original Message----- >>> From: Klaasjan Brand [mailto:[EMAIL PROTECTED]] Sent: Monday, April 08, >>> 2002 12:14 AM >>> To: Jakarta Commons Developers List >>> Subject: Re: BeanUtils and Digester Release? >>> >>> >>> Scott Sanders wrote: >>> >>>> Anyone hae any blockers that would stop the release of >>> >>> BeanUtils 1.3 >>>> or Digester 1.2? >>>> >>>> Digester has the XML rules stuff that I would like to get released, >>>> and both have had some good bugfixes. >>>> >>>> Opiniions, suggestions? >>>> >>>> Scott Sanders >>>> >>> >>> I mentioned a bug in MethodUtils a few days back: http://nagoya.apache. >>> org/bugzilla/show_bug.cgi> ?id=7740 >>> >>> I've provided a patch, but it's not yet committed. >>> >>> It would be nice if the fix would be included... >>> >>> greets, >>> Klaasjan Brand >>> >>> > --- orig/MethodUtils.java Wed Apr 3 13:50:22 2002 > +++ fix/MethodUtils.java Wed Apr 3 13:50:34 2002 > @@ -504,7 +504,7 @@ > // search through all methods > int paramSize = parameterTypes.length; > Method[] methods = clazz.getMethods(); > - for (int i = 0, size = methods.length; i < size ; i++) { > + outer: for (int i = 0, size = methods.length; i < size ; i++) { > if (methods[i].getName().equals(methodName)) { > // log some trace information > if (log.isTraceEnabled()) { > @@ -517,12 +517,12 @@ > int methodParamSize = methodsParams.length; > if (methodParamSize == paramSize) { > for (int n = 0 ; n < methodParamSize; n++) { > - if > (!parameterTypes[n].isAssignableFrom(methodsParams[n])) { > + if > (!methodsParams[n].isAssignableFrom(parameterTypes[n])) { > if (log.isTraceEnabled()) { > log.trace(parameterTypes[n] + " is not > assignable from " > + methodsParams[n]); > } > - break; > + continue outer; > } > } > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]. > org> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]. > org> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
