simon, nevermind, i don't remember what i did, but <pattern value="child"> <object-create-rule classname="xxx"/> <set-generic-properties-rule/> <set-next-rule methodname="addChild"/> </pattern>
now works with [d instanceof Digester] d.addFactoryCreate("*/set-generic-properties-rule", new SetGenericPropertiesRuleFactory()); // d.addRule("*/set-generic-properties-rule", new XPatternRule("pattern")); <--- thought i need this d.addSetNext("*/set-generic-properties-rule", "add", Rule.class.getName()); (XXGenericXX some Castor related stuff) i've been using Digester for 3 days now and haven't digged the push/pop stuff completely yet... your arguments regarding private use have been absorbed though thanks ricardo --- Simon Kitching <[EMAIL PROTECTED]> wrote: > Hi Ricky, > > You must be referring to > xmlrules/DigesterRuleParser.java > > I'm no expert on the xmlrules package. > > However it is normal practice for classes created > solely for the purpose > of implementing function X to be declared private. > > The PatternRule class appears to have been created > *not* with the > intention of providing additional services to users > of Digester, but > solely as an implementation detail of the xmlrules > functionality. As > such, private seems the appropriate scope to me. > > If you feel that the functionality of the > PatternRule is useful outside > of the xmlrules package, then consideration could be > given to > "promoting" the class to public. > > Note however that any class or method declared > public (or protected) is > part of the "public interface" to a package, and > must: > (a) be documented much more thoroughly than > private/package classes > (b) be backwards-compatible in future releases > (c) be deprecated before removal > > So a class really should only be public if it needs > to be. > > > Regards, > > Simon > > On Tue, 2003-10-21 at 10:02, Ricky Panaglucci wrote: > > hello, > > why do classes like PatternRule have private > access? > > > > now, for adding my own rules which may use > surrounding > > "pattern", i just copied the PatternRule source > [very > > brown imho] > > > > why not make them protected or public? > > > > > > ricardo > > > > > ________________________________________________________________________ > > Want to chat instantly with your online friends? > Get the FREE Yahoo! > > Messenger http://mail.messenger.yahoo.co.uk > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: > [EMAIL PROTECTED] > > For additional commands, e-mail: > [EMAIL PROTECTED] > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: > [EMAIL PROTECTED] > For additional commands, e-mail: > [EMAIL PROTECTED] > ________________________________________________________________________ Want to chat instantly with your online friends? Get the FREE Yahoo! Messenger http://mail.messenger.yahoo.co.uk --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]