The following comment has been added to this issue: Author: dion gillard Created: Wed, 6 Oct 2004 5:39 AM Body: "Off course that's getting away from standards for no legitimate reason."
The reason, so far, has been licensing and details about jstl.jar. If it's part of the standard taglibs from Apache, then fine. However, jars from Sun licensed under their Binary Code License have not been previously allowed to be distributed on ibiblio. I'm happy if we can depend on jstl.jar as the sources are part of the standard taglib. See http://cvs.apache.org/viewcvs.cgi/jakarta-taglibs/standard/src/javax/servlet/jsp/jstl/core/LoopTagStatus.java?rev=1.4.2.1&only_with_tag=STANDARD_1_0_BRANCH&view=markup So. If I replace the custom LoopStatus in ForEachTag with the JSTL one, and keep the rest, what is the difference between our patches? --------------------------------------------------------------------- View this comment: http://issues.apache.org/jira/browse/JELLY-150?page=comments#action_53753 --------------------------------------------------------------------- View the issue: http://issues.apache.org/jira/browse/JELLY-150 Here is an overview of the issue: --------------------------------------------------------------------- Key: JELLY-150 Summary: j:forEach tag not properly using varStatus attribute Type: Bug Status: Unassigned Priority: Major Project: jelly Components: core / taglib.core Versions: 1.0-beta-4 1.0 1.1-beta-1 jface-1.0-beta-1 jface-1.0 swt-1.0 1.0-beta-5 Assignee: Reporter: Ben Anderson Created: Fri, 24 Sep 2004 4:57 AM Updated: Wed, 6 Oct 2004 5:39 AM Environment: win2k / cygwin Description: According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-) --------------------------------------------------------------------- JIRA INFORMATION: This message is automatically generated by JIRA. If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]