[AARGH - I hate top-posting!!] It certainly seems like email is generally ready for release.
I think one more RC and a new VOTE thread would be a good idea, as the vote thread from december last year really can't be "continued" now :-). Besides there are a few minor things that need fixing: === website * navigation bar contains "CVS" entry (see xdocs/navigation.xml) * welcome page: * site welcome page refers to CVS * build --> built * in the examples page, "exmaples" --> "examples" * I recommend disabling the following maven reports: * changelog * developer activity * file activity These reports are of questionable use. And all date-based selection is stuffed in the apache svn repository anyway, due to cvs imports, so the reports can contain incorrect data. === code * Why does method Email.setHeaders take a Hashtable parameter? If this is an attempt to get the Email class to support JVM1.1 it won't work because this class also uses interface List. I would definitely prefer to see this method take a Map. * Shouldn't MultiPartEmail.addPart return a MultiPartEmail object? * One of the MultiPartEmail.addPart methods is missing javadoc. === downloads * the project.properties file has no "maven.compile.target" entry so what JVMs are supported will depend on what JVM was used to build the release. What exactly is the minimum JVM supported? Whatever it is, I would recommend adding maven.compile.target (and maven.compile.source) to the project.properties file *and* building the release with that JVM too. * There is no RELEASE-NOTES.txt file. === other I also see that Eric Pugh created a "tags/EMAIL_1_0" tag with message "Release 1.0 based on voted 1.0 RC4" but I think this should be deleted. Regards, Simon On Wed, 2005-06-22 at 09:41 +1000, Dion Gillard wrote: > >From what I can tell, the distributions below needed to be signed > differently and more votes are still needed. > > I'm +1 on the release, but believe we need to repackage for the release. > > Anyone else care to vote or have opinions about the distribution? > > On 3/12/05, Eric Pugh <[EMAIL PROTECTED]> wrote: > > Hi all, > > > > A couple of packaging issues were discovered in Email 1.0 RC3. I was > > encouraged to fix them and then call for a fresh vote, so I appreciate > > the understanding of the community that the (now) 4 release candidates > > it's taken to get email to 1.0. My first time signing a project. > > > > The release candidate is available at > > http://www.apache.org/~epugh/email/distributions/ and is just RC3 with > > some packaging tweaks, not Java code changes. The documentation is > > available at http://www.apache.org/~epugh/email/docs > > > > This is a full release vote (and so three +1's are required). please > > check the release before voting +1. i will not tally the votes before > > 2300 hours GMT on Tuesday 15th of March. > > > > here's my +1 > > > > - Eric > > > > -8<------------------------------------------------------------- > > [ ] +1 Promote RC4 to commons-email-1.0 > > [ ] +0 In favour of this release > > [ ] -0 Against this release > > [ ] -1 Do not release RC4 > > ---------------------------------------------------------------- > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
