On Wed, 2005-06-22 at 13:50 +0000, [EMAIL PROTECTED] wrote: > Modified: > jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java > URL: > http://svn.apache.org/viewcvs/jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java?rev=191862&r1=191861&r2=191862&view=diff > ============================================================================== > --- > jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java > (original) > +++ > jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java > Wed Jun 22 06:49:59 2005 > @@ -20,7 +20,9 @@ > import java.util.Date; > import java.util.Enumeration; > import java.util.Hashtable; > +import java.util.Iterator; > import java.util.List; > +import java.util.Map; > import java.util.Properties; > > import javax.mail.Authenticator; > @@ -178,7 +180,7 @@ > * or 2( high ) 3( normal ) 4( low ) and 5( lowest ) > * Disposition-Notification-To: [EMAIL PROTECTED] > */ > - protected Hashtable headers = new Hashtable(); > + protected Map headers = new Hashtable();
Is there a specific reason to still use Hashtable here? If not, I think HashMap might be nicer. Hashtable is synchronized, but I don't see that being relevant here (except that the Hashtable imposes a performance hit - hardly significant though in this situation). And Hashtable will not allow null keys, but I don't see that being relevant either. Regards, Simon --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
