On 6/23/05, Simon Kitching <[EMAIL PROTECTED]> wrote:
> On Wed, 2005-06-22 at 13:50 +0000, [EMAIL PROTECTED] wrote:
> 
> > -    protected Hashtable headers = new Hashtable();
> > +    protected Map headers = new Hashtable();
> 
> Is there a specific reason to still use Hashtable here? If not, I think
> HashMap might be nicer.

No reason. The original patch simply replaced the declaration.

> Hashtable is synchronized, but I don't see that being relevant here
> (except that the Hashtable imposes a performance hit - hardly
> significant though in this situation).

Yep, though it would be nicer to just use HashMap.

> And Hashtable will not allow null keys, but I don't see that being
> relevant either.
> 
> Regards,
> 
> Simon
-- 
http://www.multitask.com.au/people/dion/
"You are going to let the fear of poverty govern your life and your
reward will be that you will eat, but you will not live." - George
Bernard Shaw

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to