On 4/11/06, Martin Cooper <[EMAIL PROTECTED]> wrote: > > On 4/11/06, Henri Yandell <[EMAIL PROTECTED]> wrote: > > > > At work I compile FileUpload against the Servlet 2.4 spec. This means > > a patch so that the mock classes in the unit test will successfully > > extend the 2.4 super classes. > > > > Any interest in this being applied to fileupload? > > > Can you say more about the nature of the changes? I guess as long as the > end > result still allows FileUpload to be built and tested against the Servlet > 2.3 API, per the Maven POM, I'm not averse to enabling it to be built and > tested against the Servlet 2.4 API as well.
Servlet 2.4 added a few additional passthrough methods on the wrapper class that would need to be implemented in such a way that they use reflection to call through if the method exists, or throw some sort of exception if they don't. I'm +1 on such a change. The original theory on interfaces like HttpServletRequest was that you could break backwards compatibility with a reasonable amount of impunity, since this was something that only container vendors had to deal with. That went away with the introduction of HttpServletRequestWrapper in Servlet 2.3, which leaves all of us that rely on that interface being subject to changes that we have to deal with. -- > Martin Cooper Craig Hen > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > >
