Martin Cooper wrote:
On 5/28/06, Henri Yandell <[EMAIL PROTECTED]> wrote:
Sorry, habit.
+1
I remember Martin having pain with changelogs and things last time, so
if you or Martin remember what they were exactly that would be a good
thing to check. I couldn't see any obvious issues looking at the
report.
The problem is that it's picking up only the last 30 days of commits,
instead of all of the changes since the 1.1 release. In this case, it
doesn't even seem to have done that, since it's missed both of the bug
fixes
that we're doing this release for. ;-( (The second of those was checked in
early this month, but it was still missed.)
For the last release, I used a patched version of the Maven plugin that
Niall built to fix this. I'm not sure if the plugin itself has been fixed
since then, though, in which case all we'd need to do is change config for
it.
In version 1.9 of the changelog-plugin a new option was added that might
solve this problem. Add these lines to the project.properties file:
maven.changelog.date=lastRelease
maven.changelog.type=date
The plugin looks in the changes.xml file to find the previous release.
Fileupload has such a file so that's good. I tried this on fileupload
and the plugin choked because of an unparseable date "2006-05-??", which
is the date set for the 1.1.1 release. So I changed that date to "In
SVN" and ran maven site again and the plugin correctly picked up
"2005-12-24" from the 1.1 release.
The version we have listed for the changelog-plugin in
commons-build/pluginUpdate.txt is 1.8.2. The latest released version,
which is the one I used in my test, is 1.9.1. Perhaps it's time to
upgrade to 1.9.1?
A couple of other minor things I noticed: I'm guessing you built on a *nix
box, because the license and notice files have those line ends, which means
they don't come up right in notepad on Windows. And the manifest file says
it was built by "hen" - although around here we all know who "hen" is. ;-)
--
Martin Cooper
Hen
On 5/28/06, Niall Pemberton <[EMAIL PROTECTED]> wrote:
> +1 from me.
>
> All looks good to me - builds fine from the source distro and I tried
> the jar in my webapp with no problems (and saw the lowercase filenames
> bug fixed).
>
> Niall
>
> P.S. Henri are you going to vote?
>
> On 5/28/06, Henri Yandell <[EMAIL PROTECTED]> wrote:
> > I've prepared a release for FileUpload;
> >
> > http://people.apache.org/~bayard/fileupload/
> >
> > [ ] +1, looks good.
> > [ ] -1, nope, something needs fixing.
> >
> >
> > Will keep the vote open until Thursday (given that Monday is a
holiday
> > for many).
> >
> > [I haven't created an SVN tag for the RC1. Is there any particular
> > reason the release info says to create a tag?]
> >
> > Hen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Dennis Lundberg
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
