Is there a reason for this change? AFAIK calling toString() on a String object just returns a reference to itself - so this just seems to add clutter in my mind. Also there was discussion on this (i.e. calling toString() on a String) for this very bit of code in the following issue ticket - would have been nice to comment before arbitarily making the change
http://issues.apache.org/jira/browse/BEANUTILS-283 Niall On 6/23/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
Author: mvdb Date: Fri Jun 22 17:58:02 2007 New Revision: 549986 URL: http://svn.apache.org/viewvc?view=rev&rev=549986 Log: Prevent calling toString on a String. Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java Modified: jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java URL: http://svn.apache.org/viewvc/jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java?view=diff&rev=549986&r1=549985&r2=549986 ============================================================================== --- jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java (original) +++ jakarta/commons/proper/beanutils/trunk/src/java/org/apache/commons/beanutils/ConvertUtilsBean.java Fri Jun 22 17:58:02 2007 @@ -542,7 +542,8 @@ } converted = converter.convert(targetType, value); } - if (targetType == String.class && converted != null) { + if (targetType == String.class && converted != null && + !(converted instanceof String)) { converted = converted.toString(); } return converted; --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
