[
https://issues.apache.org/jira/browse/WSCOMMONS-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919530#action_12919530
]
Kasun Gajasinghe commented on WSCOMMONS-556:
--------------------------------------------
Hi Andreas,
Quote: "Combining the two methods in a single one only reduces the overhead by
less than 50%"
I agree with this completely. But at least it'd amount for less than 75%,
right? I think that counts!
The only change I did with help from Kishanthan to getLocalName(String) and
getPrefix(String) methods was adding DOMUtil.separator ":" as the separator.
Then, we combined the methods together as it's unnecessary overhead. So, saying
my "changes needs to be revised" is not entirely true :)
Now talking about further method optimizations for String#split, I didn't went
far about thinking RegEx object creations. But now think of it, this splitting
can be done by use of String.indexOf(":") and String.substring. Substring is a
simple Array index operation, which guarantees constant time. So, this might do
the optimization we need in those method, don't you think?
Tell me your opinion about this, and what I can do further to help?
--Kasun
> Performance improvement for axiom-dom module
> --------------------------------------------
>
> Key: WSCOMMONS-556
> URL: https://issues.apache.org/jira/browse/WSCOMMONS-556
> Project: WS-Commons
> Issue Type: Improvement
> Components: AXIOM
> Affects Versions: Axiom 1.2.9
> Environment: Java 1.5
> Reporter: Kasun Gajasinghe
> Assignee: Andreas Veithen
> Fix For: Axiom 1.2.10
>
> Attachments: axiom-dom-556-patch2.diff, axiom-perf-improvement.diff,
> FINAL-times_for_large_samples_with_changes.png,
> FINAL-times_for_small_samples_with_changes.png
>
>
> This article published [0] on April 2010, shows that Axis2 has some major
> performance issues compared to Metro and CXF. An analysis suggested that
> most of the problems were with the axiom-dom module's methods, along with
> Rampart. So, first we went on improving the axiom-dom module. Here's a patch
> for the improvements we did.
> Final assessments suggest considerable level improvement. Graphs for a
> sample run of requests with small and large samples will be added to the
> files section.
> [0] http://www.ibm.com/developerworks/java/library/j-jws14/index.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
