I just changed the checkstyle.pattern.todo property to incorporate FIXME as well.
There are lots of TODO: comments in the code. There were also a bunch of FIXME: comments which I've changed to "TODO" because checkstyle will warn us about TODO but not FIXME. Longer term we should probably change checkstyle to look for FIXME as well but for now it was easier to change those comments.
Well, the @see tags in question are so long because they refrence the fully qualified class name. Javadoc is aware of the package space and only requires a fully qualified name if there is a namespace conflict. Might as well just use the short form in the source as the generated files come out the same. I shortened two @see tags in SimpleHttpConnectionManager as proof.
Two of the javadoc "@see" tags are longer than 100 characters. Since javadoc doesn't like its tags broken onto multiple lines, I'd like to have checkstyle ignore line lengths on @see tags like it does for the header line.
While there are lots of "line is too long" warnings left, none of these are over 100 characters so assuming that we change checkstyle to have a maximum size of 100, all these will go away. (the current setting is still 80).
I just checked in the checkstyle properties.
Perhaps we should be deprecating them in favour of standard names.
Whats left after that are things that can't be changed without possibly breaking code that uses httpclient. Public or protected variables with names that don't conform to the checkstyle rules.
Thanks for going through and doing all this work Mike. Its a huge effort. When I first ran the checkstyle report it showed about 2500 violatios. There is only 188 now, with many of those being legitimate issues. I think that under 50 violations are manageable, so that we can actually see when something messy happens in the code. This would happen after URI (its 3863 lines long!) and URIUtil are tackled.
-jsd
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
