Re: Bug 16429: Align the code base with checkstyle

[Mike Bowler]

> Well, the @see tags in question are so long because they refrence the
> fully qualified class name. Javadoc is aware of the package space and
> only requires a fully qualified name if there is a namespace conflict.
> Might as well just use the short form in the source as the generated
> files come out the same. I shortened two @see tags in
> SimpleHttpConnectionManager as proof.

Good point. I've used short names in other javadoc tags so I'm not sure why I was thinking that @see was different. I'll have to blame it on lack of caffeine ;-)

> I just checked in the checkstyle properties.

Cool.

>> Public or protected
>> variables with names that don't conform to the checkstyle rules.
>
> Perhaps we should be deprecating them in favour of standard names

Sounds good to me. We can provide alternate constants with the same value for all final values and accessors with more appropriate names for the non-final variables.

> Thanks for going through and doing all this work Mike.

Not a problem. Being able to use httpclient in HtmlUnit saved (and continues to save) me a significant amount of time. It's good to be able to give something back.


--
Mike Bowler
Principal, Gargoyle Software Inc.
Voice: (416) 822-0973 | Email : [EMAIL PROTECTED]
Fax : (416) 822-0975 | Website: http://www.GargoyleSoftware.com


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]