Sorry Jeff, Friday was release day here so I got called away to fix a critical bug before that was discovered at the last moment (dang Solaris... :)
I still didn't get the patch for some reason (we have "funky" attachment stripping with our Exchange server), but will ask the user who reported the problem to verify that the problem is fixed and will close the bug if appropriate. Adrian Sutton, Software Engineer Ephox Corporation www.ephox.com -----Original Message----- From: Jeffrey Dever [mailto:[EMAIL PROTECTED]] Sent: Saturday, 8 February 2003 9:38 AM To: Commons HttpClient Project Subject: Re: [patch] for Bug 16864 I guess no comments are good comments ;-) I'll check in the patch. Jeffrey Dever wrote: > I was too hot on the send button. This'll help ;-) > > I have tests that I'm just committing now ... > > Adrian Sutton wrote: > >> Jeff, >> There was no attached patch. :) At least, not at my end.... >> >> Thanks for the quick response, I'm sure the user will appreciate it >> greatly! >> :) >> >> Adrian Sutton, Software Engineer >> Ephox Corporation >> www.ephox.com >> >> >> -----Original Message----- >> From: Jeffrey Dever [mailto:[EMAIL PROTECTED]] >> Sent: Friday, 7 February 2003 2:33 PM >> To: Commons HttpClient Project >> Subject: [patch] for Bug 16864 >> >> >> I created some tests for this issue and checked them in. >> >> Attached is a patch to fix the issue and make the tests pass, but it >> needs to be reviewed. I changed slightly the semantics of one very >> important method: HttpConnection.readLine(). >> It now requires the a "\r\n" be present as a pair to terminate the >> line (that was the root cause of bug 16846). If the end of stream is >> read before a \n\r is found, the data read up untill that point will >> be returned, whereas before this was discarded. I also tried to >> minimize the number of checks in the while loop to try and speed it >> up a bit. >> >> Please review the attached patch. >> >> Jandalf. >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: >> [EMAIL PROTECTED] >> For additional commands, e-mail: >> [EMAIL PROTECTED] >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: >> [EMAIL PROTECTED] >> For additional commands, e-mail: >> [EMAIL PROTECTED] >> >> >> >> > > >------------------------------------------------------------------------ > >--------------------------------------------------------------------- >To unsubscribe, e-mail: [EMAIL PROTECTED] >For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
