DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=26070>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=26070

[RFE] Allow streaming of POST methods via chunked transfer encoding.





------- Additional Comments From [EMAIL PROTECTED]  2004-04-28 23:34 -------
Hi Oleg,

A few comments:

- The new constructors are good, but there is a problem with the 
ByteArrayRequestEntity().  It will 
always result in an exception since it's calling this(null). 
 - I have no problem making these classes immutable, but I'm not sure it's really 
required.  What's the 
motivation?
 - I think we should wait until we move the Content-Type to add a StringRequestEntity. 
That way we can 
handle the charset problems all at once.  I had originally created a 
StringRequestEntity but left it out for 
this reason.
 - Could StringRequestEntity.writeRequest() be simplified to:

     Writer writer = null;
     if (this.charset != null) {
         writer = new OutputStreamWriter(out, this.charset); 
     } else {
         writer = new OutputStreamWriter(out); 
     }
     writer.write(content);

Mike

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to