Paul- I have redone the patch and Makefile.sfw to do what you suggest. The build works fine.
The webrev is updated http://companion.sunfreeware.com/downloads/rpmwebrev/ Steve C. paulcun at talk21.com wrote: > Steve, > > --- Steve Christensen <sunfreeware at gmail.com> wrote: > >> This is a code review request for a fix to the >> SFWrpm package files so that they will build in NV72 >> or higher. The webrev is at >> >> > http://companion.sunfreeware.com/downloads/rpmwebrev/ >> Details - >> >> In NV 72 or higher, there is now a file err.h in >> /usr/include that conflicts with a err.h file in the >> rpm source code. When a build is attempted, parts >> of the build find the /usr/include/err.h file and >> the build fails. The simplest thing to do was >> rename the rpm err.h file to errx.h and patch a few >> files to look for that instead of err.h. The code >> then builds with no problems in a nightly in NV74. >> I am open to other clever/cleaner ways to do this. > > Comment: > rather than keep a seperate copy of errx.h (which > could be out of date next time the tarball is reved) > wouldn't it have been better to have simply rename > err.h to errx.h after the tarball has been > incompressed. > > Paul >
