I am adding one more fix to this code review request. The new webrev is at
http://companion.sunfreeware.com/downloads/clobberwebrev/ The addition is in the libsane package. It was determined that if the SFWgtxt package is installed on a system, then the sane.backends.mo files will be installed by the libsane build in the proto/root_sparc/opt/sfw/lib/locale/da/LC_MESSASSES like directories. Therefore these files need to be in the pkgdefs/SFWlibsane/prototype_com file. Steve Christensen > This is a code review request for the further cleanup > of some protocmp and clobber related issues with the > Companion code. The webrev is at > > http://companion.sunfreeware.com/downloads/clobberwebr > ev/ > > The issues that have been fixed are: > > Ruby > > Some of the proto permissions were still not correct > due to how > the tmpl template files in the pkgdefs were used in > the Makefile.sfw. > This has been repaired - with code from Mike > Sullivan. > > The -x flag to $(SH) that provides debugging output > is no longer > needed. > > A > > CLOBBERFILES += prototype_$(MACH) > > line has been added to the pkgdefs/SFWruby/Makefile > so that prototype_sparc > or prototype_i386 files built from the .tmpl files > are removed during a clobber. > > Lynx > > Some permission fixes have been done to two > directories in the install-sfw file. > > Xcpustate > > Several .c files are generated by the Makefiles, but > were not always being > removed during a clobber. This has been corrected. > > Xemacs, Emacs, TeTeX, RPM > > All of these programs use prototype_sparc.tmpl or > prototypei386.tmpl files > in their pkgdefs. CLOBBERFILES lines have been > added to their Makefiles so that the > files they generate are removed during a clobber. > > Copyrights have been updated in all changed files. > > The new code builds cleanly in NV 56 on my systems. > > > Steve C. -- This messages posted from opensolaris.org
