Steve Christensen wrote: > Paul - > > Unless you object, I think I would like to make a mass copyright update > as a separate code fix later. I will write a script to check all files > that have the old form of the copyright in any directory and change the > all at once. > > OK?
that's okay with me (but the policy used to be only change the copyright lines if you change the file). It would be good to get them all the same format though :-) paul > Paul Cunningham wrote: > >> >> >> Steve Christensen wrote: >> >>> Paul - >>> >>> Thanks very much for looking at this. I have made the fixes you >>> suggest and redone the Webrev. Please take another look. >> >> >> There are still a few files with the old style 'copyright' lines (not >> that it really matters), eg. src/pkgdefs/SFW*/Makefile, otherwise >> looks okay. >> >> paul >> >> >>> Paul Cunningham wrote: >>> >>>> I haven't seen anyone else review this so I took a quick look .... >>>> >>>> It all looks good to me, just a few very minor comments (see below ..) >>>> >>>> Paul >>>> >>>> ==== Start of Comments =================== >>>> >>>> 1. src/cmd/ruby/install-sfw >>>> the indenting of the 'do' and 'done' doesn't look right to me >>>> >>>> 2. Various files (eg. cmd/xcpustate/Makefile.sfw, etc.) >>>> the copyright message probably should be of the current Sun >>>> format .. >>>> "Copyright 2007 Sun Microsystems, Inc. All rights reserved." >>>> "Use is subject to license terms." >>>> >>>> ==== End of Comments ===================== >>>> >>>> Steve Christensen wrote: >>>> >>>>> I am adding one more fix to this code review request. The new >>>>> webrev is at >>>>> >>>>> http://companion.sunfreeware.com/downloads/clobberwebrev/ >>>>> >>>>> The addition is in the libsane package. It was determined that if >>>>> the SFWgtxt >>>>> package is installed on a system, then the sane.backends.mo files >>>>> will be installed by the libsane build in the >>>>> proto/root_sparc/opt/sfw/lib/locale/da/LC_MESSASSES like >>>>> directories. Therefore these files need to be in the >>>>> pkgdefs/SFWlibsane/prototype_com file. >>>>> >>>>> Steve Christensen >>>>> >>>>> >>>>> >>>>>> This is a code review request for the further cleanup >>>>>> of some protocmp and clobber related issues with the >>>>>> Companion code. The webrev is at >>>>>> http://companion.sunfreeware.com/downloads/clobberwebr >>>>>> ev/ >>>>>> >>>>>> The issues that have been fixed are: >>>>>> >>>>>> Ruby >>>>>> >>>>>> Some of the proto permissions were still not correct >>>>>> due to how >>>>>> the tmpl template files in the pkgdefs were used in >>>>>> the Makefile.sfw. >>>>>> This has been repaired - with code from Mike >>>>>> Sullivan. >>>>>> >>>>>> The -x flag to $(SH) that provides debugging output >>>>>> is no longer >>>>>> needed. >>>>>> >>>>>> A >>>>>> CLOBBERFILES += prototype_$(MACH) >>>>>> >>>>>> line has been added to the pkgdefs/SFWruby/Makefile >>>>>> so that prototype_sparc >>>>>> or prototype_i386 files built from the .tmpl files >>>>>> are removed during a clobber. >>>>>> >>>>>> Lynx >>>>>> >>>>>> Some permission fixes have been done to two >>>>>> directories in the install-sfw file. >>>>>> >>>>>> Xcpustate >>>>>> >>>>>> Several .c files are generated by the Makefiles, but >>>>>> were not always being >>>>>> removed during a clobber. This has been corrected. >>>>>> >>>>>> Xemacs, Emacs, TeTeX, RPM >>>>>> >>>>>> All of these programs use prototype_sparc.tmpl or >>>>>> prototypei386.tmpl files >>>>>> in their pkgdefs. CLOBBERFILES lines have been >>>>>> added to their Makefiles so that the >>>>>> files they generate are removed during a clobber. >>>>>> >>>>>> Copyrights have been updated in all changed files. >>>>>> >>>>>> The new code builds cleanly in NV 56 on my systems. >>>>>> >>>>>> >>>>>> Steve C. >> >> >
