Steve,
Changes mainly look okay to me. See minor comments below ...
Paul
src/cmd/tetex/README.SFWtetex
shouldn't these show up as deleted as its now autogenerated from
the tmpl file? ie. removed from the source repository.
src/pkgdefs/SFWtetex/prototype_sparc
src/pkgdefs/SFWtetex/prototype_i386
- shouldn't these show up as deleted as they are now autogenerated
in the Makefile from the tmpl files ?
src/pkgdefs/SFWrpm/prototype_sparc
src/pkgdefs/SFWrpm/prototype_i386
- and again for rpm
src/pkgdefs/SFWtetex/depend
src/pkgdefs/SFWrpm/depend
- shouldn't these show up as deleted (from src repository) as its
now using the default depend file ?
all files
- copyright messages - should you have changed the year?
Steven Christensen wrote:
> This is a request for a code review for two packages on the Companion CD.
> The rpm and tetex install-sfw files, the protoype_sparc and
> prototype_i386 files, and a few other files have had solaris 2.9 entries
> hardcoded in. The changes documented in the webrev below
> take care of this problem so that the level of Solaris is picked up
> and put into the relevant files where needed. Some minor fixes
> taking out unneeded depend files were also done.
>
> These changes work correctly in nightly builds and in package
> installation.
>
> The webrev is at:
>
> http://companion.sunfreeware.com/downloads/rpmtetexwebrev/
>
> The actual files (to be bunzipped and untarred in usr/src) are
> in
>
> http://companion.sunfreeware.com/downloads/rpmtetex.tar.bz2
>
> Please send any comments to companion-discuss and CC to
> me at steve at smc.vnet.net <mailto:steve at smc.vnet.net>.
>
> Thanks,
>
> Steve Christensen
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss
