This is a request for a code review of the clean up of files in the pkgdefs directory. The issues dealt with are:
1. Some of the SFW directories in pkgdefs contained depend files as part of the svn repository that are actually supposed to be generated by the Makefile when the depend file is just the generic file and has no extra dependencies added to it. Some of these depends were probably put there during the SCCS to svn transition incorrectly and others added just in error. I have removed the unneeded depend files and made sure the Makefile in each SFW directory contains the DATAFILES += depend line when required. There are also some cases where i.preserve files were not needed and those have been removed and where required generated by the Makefile. 2. Some of the DATAFILES += depend lines in the Makefiles were incorrect, leaving out the + and those have been corrected. 3. There were inconsistencies in some of the prototype_com files. Some had man and info pages and directories owned by bin bin and others by root bin. Since the man pages in /usr/man are root bin, I changed those prototype_com files so that ownerships are all root bin as well. This avoids some warning messages during pkgadd's of the packages. The webrev for this is at http://companion.sunfreeware.com/downloads/dependwebrev/ The source with these changes, using Nevada 45 and svn repository revision 81, gives a nightly build with no error messages. Please send me any comments, corrections, etc. Thanks, Steve Christensen -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://mail.opensolaris.org/pipermail/companion-discuss/attachments/20061009/6f2f747c/attachment.html>
