Looks good, just some minor comments ...
Paul
==== Start comments ====================================
1. src/pkgdefs/SFWxmms/prototype_com
- typo - upper case characters ..
+d none sfw/man/man1 755 rooT BIN
2. src/pkgdefs/SFW*/i.preserve
- I assume that these have been deleted because there is a
default script and these shouldn't have got into the
source repository
3. A bit of history
- the usr/group settings on the man/man* directories were wrong
because that is how they were for s8 (in /usr/share/man/man*) -
we were always going to change them for s9/s10 but somehow
we never got around to doing it. At last they have been
corrected :-)
4. A bit more history
- the binary packages that have 'depend' files that have the
same content as the 'default depend' was done intentionally,
so that if the package ever needed extra dependencies it was
easier to add them (single file edit). I'm happy that you
have changed these though.
5. source package dependencies - comments -
- I'm not really sure that the source packages pkgdefs/SFW*S need
dependencies, default or otherwise, as they don't depend on
anything IMO.
==== End comments ======================================
Steven Christensen wrote:
> This is a request for a code review of the clean up of files in the pkgdefs
> directory. The issues dealt with are:
>
> 1. Some of the SFW directories in pkgdefs contained depend files as
> part of the
> svn repository that are actually supposed to be generated by the
> Makefile when
> the depend file is just the generic file and has no extra dependencies
> added to
> it. Some of these depends were probably put there during the SCCS to svn
> transition incorrectly and others added just in error.
>
> I have removed the unneeded depend files and made sure the Makefile in
> each SFW directory contains the DATAFILES += depend line when required.
> There are also
> some cases where i.preserve files were not needed and those have been
> removed
> and where required generated by the Makefile.
>
> 2. Some of the DATAFILES += depend lines in the Makefiles were
> incorrect, leaving out the + and
> those have been corrected.
>
> 3. There were inconsistencies in some of the prototype_com files. Some
> had
> man and info pages and directories owned by bin bin and others by root
> bin. Since
> the man pages in /usr/man are root bin, I changed those prototype_com
> files so
> that ownerships are all root bin as well. This avoids some warning
> messages during
> pkgadd's of the packages.
>
> The webrev for this is at
>
> http://companion.sunfreeware.com/downloads/dependwebrev/
>
> The source with these changes, using Nevada 45 and svn repository
> revision 81,
> gives a nightly build with no error messages.
>
> Please send me any comments, corrections, etc.
>
> Thanks,
>
> Steve Christensen
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss
