Steve,

This looks good to me; just a few minor comments ....

Paul

== Star Comments ===================================

1. src/cmd/fetchmail/install-sfw +
    src/pkgdefs/SFWftchm/prototype_com
   - why did you take out the localization stuff?

2. src/pkgdefs/SFWftchmS/prototype_i386 +
    a number of other files
   - the sun copyright messages in these files should probably
     be changed so that they conform to Sun's current format; which
     was as in src/cmd/fetchmail/DISTFILES.sfw but they may have
     changed it again since I last did anything.

3. src/pkgdefs/SFWftchm/pkginfo.tmpl +
    src/pkgdefs/SFWftchmS/pkginfo.tmpl
   - version number needs changing to 6.3.4 (in a number of places)

== End Comments ===================================

Steven Christensen wrote:
> This is a request for a code review of an update of the Companion CD 
> fetchmail package.
> Fetchmail version 6.2.5 is updated to 6.3.4.  The fetchmail source comes 
> from
> 
> http://fetchmail.berlios.de/ <http://fetchmail.berlios.de/>
> 
> The webrev can be found at
> 
> http://companion.sunfreeware.com/downloads/fetchmailwebrev/
> 
> and the new fetchmail files at
> 
> http://companion.sunfreeware.com/downloads/fetchmail.tar.bz2
> 
> In addition to an upgrade, ssl support has been added.  The code
> builds correctly for Nevada 45 in a nightly build of all packages.
> 
> The fetchmail.tar.bz2 file should be bunzipped and untarred in
> usr/src.  The Targetdirs file is changed to include python2.4 directories
> for the fetchmailconf.py file.
> 
> Thanks,
> 
> Steve Christensen
> 
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss

Reply via email to