Steve,
My review comments are below, otherwise it looks okay ....
Paul
=== Start of comments =====================
1. all new files
- shouldn't the copyright year be 2006
- remove the old sccs id lines
2. src/pkgdefs/SFWaoS/copyright
- this still contains the 'libogg, libvorbis:' copyright bits
3. src/cmd/vorbis-tools/Makefile.sfw
- shouldn't this file have a 'CDDL HEADER' header
4. src/lib/libao/install-sfw
- should the 'chown root:bin' lines still be in here
5. src/pkgdefs/SFWaoS/pkginfo.tmpl +
src/pkgdefs/SFWao/pkginfo.tmpl
- shouldn't the lines containing the version number be 0.8.3
for libao (& not 1.0 from libvorbis)
=== End of comments =======================
Steve Christensen wrote:
> This is a request for a code review. It has been pointed out that the libogg
> and libvorbis packages are no longer needed as they have been included in
> Solaris. I have removed these two packages and moved the libao code to the
> main usr/src/lib directory. I have modified the pkgdefs and Makefiles to
> take this into account. I also modified the vorbis-tools package to see the
> libogg and libvorbis files in /usr/lib. No other programs have a dependency
> on these libraries. The webrev is at
>
> http://companion.sunfreeware.com/downloads/oggwebrev/
>
> I have done a clean build with Nevada 45 with these changes.
>
> Thanks,
>
> Steve Christensen
> --
> This messages posted from opensolaris.org
> _______________________________________________
> companion-discuss mailing list
> companion-discuss at opensolaris.org
> http://opensolaris.org/mailman/listinfo/companion-discuss
>
