Steve, See in comment block below ......
Paul Steve Christensen wrote: > > Thanks for the corrections which I have made in the various places. I > added the CDDL to the install-sfw in the vorbis-tools as well. Please > take another look. > > http://companion.sunfreeware.com/downloads/oggwebrev/ > > > Paul Cunningham wrote: >> >> My review comments are below, otherwise it looks okay .... >> >> >> === Start of comments ===================== >> >> 1. all new files >> - shouldn't the copyright year be 2006 >> - remove the old sccs id lines >> >> 2. src/pkgdefs/SFWaoS/copyright >> - this still contains the 'libogg, libvorbis:' copyright bits >> >> 3. src/cmd/vorbis-tools/Makefile.sfw >> - shouldn't this file have a 'CDDL HEADER' header >> >> 4. src/lib/libao/install-sfw >> - should the 'chown root:bin' lines still be in here Have you changed this file, it still has wrong copyright, sccs id, and chown ... http://companion.sunfreeware.com/downloads/oggwebrev/src/lib/libao/install-sfw.html >> 5. src/pkgdefs/SFWaoS/pkginfo.tmpl + - version number not changed - I think (if I remember correctly) this needs doing in more than one place in the file (see other packages, eg SFWcups) - sccs id not removed >> src/pkgdefs/SFWao/pkginfo.tmpl >> - shouldn't the lines containing the version number be 0.8.3 >> for libao (& not 1.0 from libvorbis) - version number - are there other places it needs changing also in the file 6. src/pkgdefs/SFW*/copyright - just a thought .... should the package 'copyright' files have the 'CDDL HEADER' header stuff in them as this will be output during 'pkgadd' invocations? If not this applied to ALL the packages and source packages in src tree. >> === End of comments ======================= >> >> >> Steve Christensen wrote: >> >>> This is a request for a code review. It has been pointed out that >>> the libogg and libvorbis packages are no longer needed as they have >>> been included in Solaris. I have removed these two packages and >>> moved the libao code to the main usr/src/lib directory. I have >>> modified the pkgdefs and Makefiles to take this into account. I also >>> modified the vorbis-tools package to see the libogg and libvorbis >>> files in /usr/lib. No other programs have a dependency on these >>> libraries. The webrev is at >>> >>> http://companion.sunfreeware.com/downloads/oggwebrev/ >>> >>> I have done a clean build with Nevada 45 with these changes. >>>
