Steve Christensen wrote: > Paul - > > I have added a comment to the SFWter/prototype_com file indicating where > to look for the source of the SFWter files. The webrev has been updated.
looks okay to me paul >> >>Steve Christensen wrote: >>> >>>See my comments below. >>> >>>Steve C. >>> >>> >>> http://companion.sunfreeware.com/downloads/sfwterwebrev >> >>>>Comments .. >>>> >>>>1. Shouldn't there be some source code bits also >> >>(or >> >>>>weren't they >>>>removed when the packaging bits were removed) ? >>> >>> >>>The files packaged in SFWter are created when the >> >>screen package is built, but >> >>>are not included in SFWscrn. The sources are >> >>therefore in SFWscrnS. There is >> >>>no need for SFWterS. >> >>okay, silly me I should have remembered that. But >>maybe the >>SFWter/prototype_com file should state where the >>files come from. >> >>paul >> >> >>>>2. 'copyright' file looks wrong >>> >>> >>>The latest webrev puts the same copyright file as >> >>SFWscrn/copyright for now. >> >>>This includes the GPL notice (not the full GPL >> >>document though). >> >>> >>>>3. Copyright messages in other files are of wrong >>>>format >>> >>> >>>Looking at a number of the copyright files in many >> >>of the packages seems to >> >>>have the same for as the SFWter. >>> >>>If these are of the wrong form, then I propose they >> >>all be changed at once >> >>>rather than just here. I can make these more >> >>global changes this week sometime. >> >>> >>>>Paul >>> >>>-- >>>This messages posted from opensolaris.org >>>_______________________________________________ >>>companion-discuss mailing list >>>companion-discuss at opensolaris.org >>> >> >>http://opensolaris.org/mailman/listinfo/companion-disc >>uss >> >>_______________________________________________ >>companion-discuss mailing list >>companion-discuss at opensolaris.org >>http://opensolaris.org/mailman/listinfo/companion-disc >>uss >> > > -- > This messages posted from opensolaris.org > _______________________________________________ > companion-discuss mailing list > companion-discuss at opensolaris.org > http://opensolaris.org/mailman/listinfo/companion-discuss >
