Stephen Warren wrote: > On Wed, March 26, 2008 11:55 pm, Phil Dibowitz wrote: >> Stephen Warren wrote: >>> That was easy - I'd just accidentally included the hunk that fixed the >>> C++ v.s. C comment at the end of libharmony.h, which you already >>> committed separately, which caused the conflict. >>> >>> So, here's the updated version, attached. >> OK, some more comments. >> >> extract_firmware_binary() >> >> I thought the whole _point_ of this patch was to do this dynamically, but >> yet you're still assuming FIRMWARE_SIZE > > This change was just to fix all the APIs for data other than the firmware > blob itself. A second pass could be made to fix up all the firmware related > APIs.
That can't be, because before my recent patch (i.e. when you first purposed this patch) the firmware API *only* returned a blob. And it returned a blob of FIRMWARE_SIZE and that's _specifically_ what you objected to. Of course, after my recent change, I started reading in the XML as well, without passing back a size, but your objection came before that patch when firmware only ever dealt with a blob. If we're going to change the API "for consistency" then let's be consistent. >> verify_xml_config() >> >> You removed the size-check - why? > > It got moved into find_config_binary, since it's a common check for both > functions. Hmm. I see. But we expect the user to call verify_xml_config() and then find_config_binary()... yet, in your code, verify_xml_config() calls find_config_binary _as_ _well_! This seems silly. Perhaps we should expect the user to call find_config_binary() first and then pass in the relevant pointers to verify_xml_config()? Or perhaps we should combine the functions such that there's just find_config_binary(), and it automatically does the verification and returns an error if there's a problem (or, I suppose, we could pass in a flag on whether or not we want the verification done)? I think I like the later better... but I'm willing to listen to any arguments. -- Phil Dibowitz [EMAIL PROTECTED] Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Never write it in C if you can do it in 'awk'; Never do it in 'awk' if 'sed' can handle it; Never use 'sed' when 'tr' can do the job; Never invoke 'tr' when 'cat' is sufficient; Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
