So I've written a patch to port libconcord over to libusb 1.0.

However, I mostly did it just as an exercise to see the differences. It is
unclear to me if this is the right route to go.

The benefits are:
* 1.0 is actively developed and used
* Using 1.0 makes the code cleaner and easier to read
* The debugging in 1.0 is nicer
* 0.1 won't get any development other than major bugfixes (probably not an
issue for us)
* It's *possible* libusb-1.0 works better on mac than 0.1. I'm not sure.

The downsides are:
* No Windows support (we don't use libusb on windows anyway, but our code
technically supports doing this if someone wants to)
* No libhid support (see more on this below)

Other Notes:
* libusb-0.1 still has a ton of things using it and isn't going anywhere
anytime soon
* there's no problem with the current code

A few notes on libhid:
* I've considered porting to libhid instead of doing it ourselves...
however, for interrupt writes, which is what we do, there's no real benefit,
other than getting the max read/write size from the "proper place" in the
HID descriptor - but I've never seen them differ from the device descriptor.
* Clearly this doesn't affect us now, but if wanted to use libhid we'd
either need to use the libusb-0.1 compat layer, or... not use libhid.
* libhid was pulled from debian recently for lack of maintainership. I
suspect the maintainer of libconcord would probably pick it up, but it's
worth nothing another dependency for not a lot of benefit.

So, what do people think? I filed a bug to track this here:

https://sourceforge.net/tracker/?func=detail&aid=3031853&group_id=201579&atid=978130

and posted a patch if you're interested in seeing what the code changes look
like. I can post the patch here for review, if people generally like the
idea of this change.

-- 
Phil Dibowitz                             [email protected]
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Be who you are and say what you feel, because those who mind don't matter
 and those who matter don't mind."
 - Dr. Seuss


Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
concordance-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to