On Mon, 23 Jul 2012, Stephen Warren wrote: >> +import threading > > It'd be better to simply consistently use thread rather than mixing > thread and threading. > >> -version = "15+" >> +version = "16+" > > Functional patches shouldn't touch the version; it should only be bumped > during or right after release. > > Hmm. I've made sure that congruity to date can run with almost any > version of libconcord. That change breaks this feature. Isn't there a > way to introduce support for the new libconcord APIs without making it > non-backwards-compatible? > >> - (f, fcontext) = context >> - percent = (current * 100) / total >> - f(False, percent, fcontext) >> + if isinstance(context, ProgramRemotePanelBase): > > That's not very object-oriented; it'd be better to call a > function/method in the context object, and have that function do > whatever is appropriate, rather than having the code query the type of > the context and then act differently. > > Uggh. Why can't libconcord parse the file without being attached to the > remote; the file format should be completely standalone and parse-able > "offline". > >> @@ -688,7 +694,6 @@ class ProgramRemotePanelBase(WizardPanelBase, Deco >> >> self.dc = DecoratedContainer(self, self.resources) >> DecoratedContainerThreadMixin.__init__(self, self.dc) >> - self._AddWidgets() >> self.sizer.Add(self.dc, 0, wx.EXPAND | wx.ALL, 5) > > This and the related changes will cause a horrible regression in the > utility of the GUI; the poor user will just see more and more tasks > randomly appearing, and have no idea when the end is in sight. congruity > may as well embed a vte (terminal) widget and just run the concordance > application in it given this change. I've complained about this > libconcord API change repeatedly before...
At long last I have finally worked on another revision of the Congruity port to the new libconcord API. I believe I have addressed all of your comments to the original patch. The major changes were to add support back in for the older API's - Congruity should support the new libconcord API as well as the previous ones. Additionally, I have proposed a libconcord API change to allow Congruity to get an idea of what events are going to happen beforehand so the UI can have all of the widgets drawn beforehand. The patch is available in the Congruity git and also attached to the Sourceforge bug, if you or anyone has any further comments or would like to test it. Thanks, Scott ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
