On 07/05/2013 08:14 PM, Scott Talbert wrote: > Signed-off-by: Scott Talbert <s...@techie.net>
Can you use the format that git expects for format-patch? i.e. a one-line title/description followed by two newlines, followed by the longer description if necessary? format-patch should then use the first for the subject and the rest for the body... > - // usbnet remotes seem to use a more normal byte ordering for serial #'s > - if (is_usbnet_remote() || is_mh_remote()) { > + // Non-HID remotes seem to use a more normal byte ordering for serial #'s > + if (is_z_remote() || is_mh_remote()) { We had it BACKWARDS and nothing noticed? How did this not break all non-mh remotes? > //memcpy(data, pkt + 6, len); > - memcpy(data, pkt + 1, len + 3); > + /* > + * pkt[0] is the index of the last byte, which means it is equal to the > + * length of the packet minus one byte. We want to copy everything but > the > + * first byte, so we copy pkt[0] bytes. > + */ > + memcpy(data, pkt + 1, pkt[0]); > return 0; Then we can nuke the calculation of 'len' here, right? And probably those commented out bits too... -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel