On Tue, 23 Jul 2013, Phil Dibowitz wrote:

>>      //memcpy(data, pkt + 6, len);
>> -    memcpy(data, pkt + 1, len + 3);
>> +    /*
>> +     * pkt[0] is the index of the last byte, which means it is equal to the
>> +     * length of the packet minus one byte.  We want to copy everything but 
>> the
>> +     * first byte, so we copy pkt[0] bytes.
>> +     */
>> +    memcpy(data, pkt + 1, pkt[0]);
>>      return 0;
>
> Then we can nuke the calculation of 'len' here, right?
>
> And probably those commented out bits too...

Actually, it looks like 'len' is used elsewhere, so we can't get rid of 
that.  I'll send a new patch with the commented lines deleted and the 
commit message reformatted.

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to