On 08/10/2013 04:56 PM, Scott Talbert wrote:
> I haven't checked out the patch yet, but I'm still having trouble seeing 
> the value in switching to libhid on Linux.  Essentially, we'd be adding 
> another layer on top of libusb (when we have a perfectly good libusb 
> implementation) and requiring a library that isn't packaged by any 
> distros.  I know you said that libraries will get packaged when other 
> packages need them, but that's easier said than done.  Concordance 1.0 
> only recently made it into Fedora and Debian (after ~4 months), and that 
> was after a *lot* of nagging on my part.  I think the fact that it isn't 
> packaged also tells us that there aren't a lot of other users, at least on 
> Linux.
> 
> I think at the very least, we shouldn't get rid of the libusb 
> implementation.  Perhaps we could make it a 'configure' option to pick 
> between the implementations.

I think that it simplifies the code a *lot*, it's one implementation across
all platforms (we should be able to drop the windows code too), it's what the
libusb developers recommend (which means that it'll get into more and more
distros), and it's a bunch of code we don't have to maintain.

I'm happy to do nagging of the distro people, I just stopped paying attention
at some point... but hidapi is the easiest thing int he world to package. It's
one file, and the git version supports building a shared library right out of
the box.

We could do a grace period though where we have both for two versions and a
bunch of warnings if you compile with the libusb version.

It also moves us to libusb-1.0 (we're on 0.1 at the moment) which... if we're
going to re-write that layer, we might as well move to the right thing.

-- 
Phil Dibowitz                             p...@ipom.com
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Be who you are and say what you feel, because those who mind don't matter
 and those who matter don't mind."
 - Dr. Seuss


Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
concordance-devel mailing list
concordance-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/concordance-devel

Reply via email to