On 08/26/2013 08:26 PM, Scott Talbert wrote: > On Tue, 30 Jul 2013, Scott Talbert wrote: > >> On Mon, 29 Jul 2013, Phil Dibowitz wrote: >> >>>> In preparation for supporting IR learning for ZWave, change the IRLearn() >>>> function to be a subclass function for each so that IR learning can be >>>> implemented and easily merged for each type separately. >>> >>> I'm totally fine with this. Out of curiosity though, do you actually expect >>> there to be much of a difference? Since you can call Read() and Write() and >>> have them do the right thing, I would imagine they'd be roughly the same... >>> but if you've started digging and say they're likely to be pretty divergent, >>> we can go this path. If, however, it's the case where there's just one extra >>> step on one side or the other, it might be nice to keep them in one place... >> >> Yes, I've started looking at this a bit and I think they are going to be >> fairly different implementations (especially with the whole UDP vs TCP >> mode of ZWave-HID and switching between the two). >> >> I actually started working on the USBNet version quite a while back, but I >> didn't get it working yet, and I have fairly limited access to that >> remote. > > Bump. Did you have any more comments on this patch?
Committed. Sorry, I totally just lost this one before. -- Phil Dibowitz p...@ipom.com Open Source software and tech docs Insanity Palace of Metallica http://www.phildev.net/ http://www.ipom.com/ "Be who you are and say what you feel, because those who mind don't matter and those who matter don't mind." - Dr. Seuss
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk
_______________________________________________ concordance-devel mailing list concordance-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/concordance-devel
