On Thu, Nov 19, 2009 at 12:12:07AM +1030, David Kettler wrote: > >Can you tell me steps to reproduce the problem, to help me understand the > >situation being addressed here? > > With the new index-webjump mode, the xpath webjumps are unusable > without completions being available, so the index webjump completer > will throw an error in that case. Without this patch, the error will > be discarded, so the user won't see the explanation and won't know why > there are no completions. > > You can see the problem by defining such a webjump, e.g.: > > define_xpath_webjump( > "gitdoc", > "http://www.kernel.org/pub/software/scm/git/docs/";, > '//xhtml:dt/xhtml:a', > $description = "Git documentation"); > > Do not call webjump-get-index. Now press "g gitdoc g". The last "g" > will try to load the completions, which will fail. Without this patch > the user won't know why. > > But see also my reply to [PATCH] Let completion functions set the > match_required state. > > There may be other ways to currently trigger such an error, and future > changes might introduce more. It's a good general principle to give > the user info about what failed.
Oh okay, sounds like a good thing then. -- John Foerch _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
