>> annotation mode. A new class, registered_stylesheet_mode, is defined >> to keep track of the features. > > I would like to make a case against an extra layer of abstraction here. > First point - we only have one caller for registered_stylesheet_mode - we > don't gain anything by abstraction. Second point - perhaps a subtle one - > registering a stylesheet is what minibuffer-annotation-mode *does*, not > what it *is*. That is, the fact that it uses a stylesheet to do its job > is an implementation detail, not its role in the system, so the added > abstraction doesn't aid readability. If we ever needed the mode to do > anything other than manage a stylesheet, the presence of the abstraction > would actually be a hindrance.
Fair enough. I had written it more directly at first, but then added the layer of abstraction to make it neater to write a walnut test for it. Will reify. Regards, David _______________________________________________ Conkeror mailing list [email protected] https://www.mozdev.org/mailman/listinfo/conkeror
