Hi Daniel,
On Thu, Feb 03, 2011 at 05:33:29PM +0100, Daniel Wagner wrote:
> diff --git a/src/ipconfig.c b/src/ipconfig.c
> index 6ef39c5..a2f198c 100644
> --- a/src/ipconfig.c
> +++ b/src/ipconfig.c
> @@ -1122,6 +1122,17 @@ enum connman_ipconfig_method
> __connman_ipconfig_get_method(struct connman_ipconf
> return ipconfig->method;
> }
>
> +int __connman_ipconfig_set_ipv4(struct connman_ipconfig *ipconfig, const
> char *address,
> + const char *netmask, const char *gateway)
> +{
> + if (ipconfig == NULL)
> + return -EINVAL;
> +
> + connman_ipaddress_set_ipv4(ipconfig->address, address, netmask,
> gateway);
> +
I think it would just make sense to get rid of connman_ipaddress_set_ipv4().
It's only called in ipconfig.c, so you could replace it with a
__connman_ipconfig_set_ipv4() call.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
_______________________________________________
connman mailing list
[email protected]
http://lists.connman.net/listinfo/connman
