Hi Samuel, On Mon, Feb 07, 2011 at 01:13:35AM +0100, Samuel Ortiz wrote: > > The current __connman_service_append/remove_nameserver allows only > > changing nameserver for the manual (e.g. non DHCP) setup. > It is also currently used by the DHCP code, by setting the IPv4 element > nameserver string.
I realized that later. I'll update the commit messsge. > > Additional the two function take now the type of nameserver (automatic > > or manual) and do append or remove the nameserer from the defined list > > of nameservers. > > I'm not sure this disctinction is needed. It should be possible to have only get/set nameserver which will only work on nameservers (dhcp, vpn, etc). > We currently have nameserver and nameservers, but what we should really have > are nameservers and nameservers_config. nameservers should be used for DNS > settings coming from the network, while nameservers_config should hold the > ones coming from Nameservers.Configuration. The nameservers_config should > override the nameservers one. Okay > So the logic here is easy: Anything you get from DHCP, VPN or fixed 3G > settings should belong to nameservers, while entries arriving from a > Nameservers.Configuration property setting should be going to > nameservers_config and all existing resolver entries should be removed and > replaced by the nameservers_config ones. > Moreover, a manually set service should use the DNS entries from > nameservers_config, if they exist. Thanks for the explanetion. This makes more sense than my _AUTO vs. _MANUAL. > What the code is currently lacking is: > - The nameservers and nameservers_config arrays. > - VPN, DHCP and 3G fixed networks filling the nameservers array. > - Manually configured services using the nameservers_config array (filled from > either service_load or Nameservers.Configuration). > - nameservers_config priority over nameservers. Should be no problem to get this done. Let me spin a patch ;) cheers, daniel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
