On Mar 14, 2011, at 9:52 AM, Daniel Wagner wrote:
> /me is trying to do some reviews :)
I appreciate the feedback and input.
>> src/etc/connman-dbus.conf | 16 +++
>> src/etc/connman-polkit.conf | 11 ++
>> src/etc/connman.conf | 25 +++++
>
> Personally, I don't think there is need to have a sub dir for the
> three config files. Let's see what Samuel or Marcel's opinion is.
Agreed. However, the current make file rules create
${builddir}/src/connman.conf from one of either connman-dbus.conf or
connman-polkit.conf, depending on the package configuration. To avoid smashing
the new read-only connman.conf with the aforementioned dynamically-created one,
I created the subdirectory.
>> + if (option_rlimits) {
>> + __connman_rlimits_init(option_file ? option_file :
>> CONNMAN_CONF_FILE);
>> + }
>> +
>
> I realise that connmand expects always to get a connman.conf, right?
> Is this desirable?
It'll happily work without one. In that case, the keyfile that gets created is
empty, no key/value pairs get populated and assigned and all is well.
Best,
Grant
_______________________________________________
connman mailing list
connman@connman.net
http://lists.connman.net/listinfo/connman
