Hi Tim, On 01.03.2012 22:07, Tim Sander wrote: > Hi Daniel >>> This patch corrects the interface so that the "net.connman.Clock" >>> interface accepts variant types as advertised in introspection. >> >> Thanks for your patches. I have applied them after fixing up some >> style issues. >> >> Next time, please send patches proper git patches (e.g. git >> format-patch) instead of plain diff patches. > Thanks for your effort. I was not aware that "git diff" produces different > results than "git format-patch". Sorry for that.
No problem. Thanks for taking the time to send a fix. I find the the git manual a very useful source of information, e.g. http://schacon.github.com/git/user-manual.html#patch-series gives you a nice overview of a workflow for creating patches. Normally, I do following: $ hack hack $ git add $ git commit $ git format-patch origin -o /tmp/patches-to-send --cover-letter --subject-prefix="RFC v0" $ git send-email /tmp/patches-to-send cheers, daniel _______________________________________________ connman mailing list [email protected] http://lists.connman.net/listinfo/connman
