Ainsi parlait Luca Berra :
> er, it is bash_completion fault.
> ---
> if [ "$PS1" ]  && [ "$SHELL" = "/bin/bash" -a -f /etc/bash_completion ];
> then
> ---
> it should check for $BASH $BASH_VERSION or similar, not $SHELL which is
> set by login.
Good point. Moreover, it should just test if $BASH variable is defined, as 
even when bash is used as /bin/sh completion is allowed.

Please apply attached patch and report any problem.

> zsh completions should be modified independently from bash.
> zsh has it own completion metod, and has had it for much longer than
> bash, i do not use bash, so i will not compare the two.
zsh completion primitives are way much better than bash completion primitives. 
However, it seems there is less active development for zsh completion 
function, whereas bash-completion project is very active.

-- 
A clean and dry set of overalls is a magnet for mud and rain
                -- Murphy's Bush Fire Brigade Laws n°16
--- bash-completion.sh~	2003-09-10 17:25:25.000000000 +0200
+++ bash-completion.sh	2003-09-10 17:24:46.000000000 +0200
@@ -1,4 +1,4 @@
-if [ "$PS1" ]  && [ "$SHELL" = "/bin/bash" -a -f /etc/bash_completion ]; then
+if [ "$PS1" ]  && [ -n "$BASH" -a -f /etc/bash_completion ]; then
 	# PS1 is set: we're in interactive shell
 	# Source completion code
     . /etc/bash_completion

Reply via email to