[ 
https://issues.apache.org/jira/browse/HADOOP-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626435#action_12626435
 ] 

Amar Kamat commented on HADOOP-3245:
------------------------------------

Got an offline review from Devaraj. Comments are as follows :
1) isJobName could be named isJobNameValid
2) isJobDirClean could be named isJobDirValid
3) Revert the changes w.r.t Jobtracker state
4) The check for {{job.hasRestared()}} is redundant in 
{{RecoveryManager.recover()}}
5) JIP constructor should not do recovery. Refactor it and call from Jobtracker
6) Revert changes to job id
7) Revert changes to history filename and use filters for _detecting_ the 
filename
8) Upon recovery, Jobtracker should not wait for all the jobs to be 
initialized. It should check if there is any history (w.r.t attempts) available 
and only then should wait for the initialization
9) Use job-priority for detecting if there are job level (meta) information 
available instead of num-attempts found/recovered
10) Counter should be logged at TIP level rather than attempt level
11) Remove Tasktracker-hostname logging and user tracker-name to find out the 
hostname.
12) Existence of an attempt should not be known to the Jobtracker. Move the 
logic back to job and tip.

Vivek suggested to do {{Job.init()}} inside the jobtracker's recovery process 
and update the scheduler.


> Provide ability to persist running jobs (extend HADOOP-1876)
> ------------------------------------------------------------
>
>                 Key: HADOOP-3245
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3245
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: mapred
>            Reporter: Devaraj Das
>            Assignee: Amar Kamat
>         Attachments: HADOOP-3245-v2.5.patch, HADOOP-3245-v2.6.5.patch, 
> HADOOP-3245-v2.6.9.patch, HADOOP-3245-v4.1.patch, HADOOP-3245-v5.13.patch, 
> HADOOP-3245-v5.14.patch, HADOOP-3245-v5.26.patch, 
> HADOOP-3245-v5.30-nolog.patch
>
>
> This could probably extend the work done in HADOOP-1876. This feature can be 
> applied for things like jobs being able to survive jobtracker restarts.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to